find_file utility handles absolute path #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready after review. |
jlstevens
reviewed
Dec 18, 2016
| """ | ||
| matches = [] | ||
| if os.path.isabs(filename) and os.path.isfile(filename): | ||
| return filename | ||
| for root, _, filenames in os.walk(folder): | ||
| for filename in fnmatch.filter(filenames, filename): | ||
| matches.append(os.path.join(root, filename)) |
There was a problem hiding this comment.
Might be worth avoid overwriting the filename argument with the return values of fnmatch.filter (i.e it might be worth calling it fname in this loop).
|
Addressed your comment, ready to merge after tests pass. |
|
Just to say that I do think being to change the layout using CSS would be useful. Ideally, we could provide alternate CSS stylesheets and an API to switch them between them that is nicer than setting file paths. Anyway, that could be a separate feature request and this PR would help make it possible. As the tests have passed, I'll merge now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the
find_fileutility can handle an absolute filename path passed to it. The function ensures that the default widget assets get resolved correctly but the user should be able to override these with an absolute path.Concretely you can now supply custom CSS to the widgets to change the layout a bit. Setting:
can give you something like this: