Fixed output magic message when backend unavailable #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now with a custom exception message:
I think this PR is ready to review/merge. I am happy to improve the exception message if you have other suggestions. |
|
What will happen if you ask for backend='powerpoint', i.e. one that truly doesn't exist? it would be nice if it were clear whether it's just nonsense/typo, or if there was a missing step. I understand that might not be practical, of course. |
|
Good suggestion! I don't think it would be too hard though I don't know if we have a list of all possible backend names somewhere I can use... |
jbednar
reviewed
Jan 10, 2017
|
|
||
|
|
||
| raise ValueError(OutputMagic.backend_list, value) | ||
| # raise ValueError("Backend %r not available. Has it been loaded with the notebook_extension?" % value) |
|
With the last commit, you have two cases:
and
I think this PR is now ready for final review/merge. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #999 regarding the inappropriate error message when trying to load an unavailable backend. Here is the old behavior:
And the new behavior:
I've tried to make a minimal fix. That said, the output message might suggest how to load the backend with
notebook_extension...