Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct dpi in MPLRenderer.get_size #1143

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Use correct dpi in MPLRenderer.get_size #1143

merged 1 commit into from
Feb 21, 2017

Conversation

philippjfr
Copy link
Member

Following on from #1140 it turns out the matplotlib equivalent to get the plot size in pixels is also incorrect using the wrong dpi.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: mpl labels Feb 21, 2017
@jlstevens
Copy link
Contributor

I don't get why plot.state.dpi isn't always the right dpi value to use....why wouldn't it match self_or_cls.dpi if output by the same renderer?

@philippjfr
Copy link
Member Author

Because the dpi is controlled by the renderer and the plotting classes don't fiddle with the default dpi value on the figure.

@jlstevens
Copy link
Contributor

Ok. Is it ready to merge then?

@philippjfr
Copy link
Member Author

Yes.

@jlstevens jlstevens merged commit e5a9a6c into master Feb 21, 2017
@philippjfr philippjfr deleted the mpl_get_size branch February 23, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: backend: mpl type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippjfr @jlstevens