Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up unicode handling #1210

Merged
merged 1 commit into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Mar 15, 2017

Includes renaming of safe_unicode (addressing #632) and more consistent usage of Dimension.pprint_label and Dimension.pprint_value.

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the unicode_cleanup branch from bbb1d87 to ab51159 Mar 15, 2017

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 16, 2017

Ready to merge.

@jlstevens jlstevens merged commit 3a46989 into master Mar 16, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 78.562%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the unicode_cleanup branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.