Handle bug in gridded groupby when dropping dimensions #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
philippjfr
force-pushed
the
xarr_groupby_drop
branch
from
d3fa761
to
b613c68
Compare
|
Ready. |
jlstevens
reviewed
Mar 21, 2017
| @@ -117,7 +117,8 @@ def init(cls, eltype, data, kdims, vdims): | |||
|
|
|||
| @classmethod | |||
| def validate(cls, dataset): | |||
| pass | |||
| if len(dataset.vdims) > 1: | |||
There was a problem hiding this comment.
Always good to have some extra validation!
|
Looks good and extra tests are always worthwhile. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios dropping dimensions in a gridded groupby would not behave correctly. This fixes the bug and adds some tests.