Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ElementOperation to process NdLayout types #1228

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Conversation

philippjfr
Copy link
Member

Partial fix for #1107, while we haven't addressed the issue about (Nd)Overlays, this is a straightforward addition that let's ElementOperations process NdLayouts just as it already handles GridSpaces.

@philippjfr philippjfr added the type: feature A major new feature label Mar 24, 2017
@jlstevens
Copy link
Contributor

Looks good and I see now reason why NdLayout should be excluded from operations.

I do think it might be worth adding a simple NdLayout operation in the unit tests to make sure the plumbing works as expected.

@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens jlstevens merged commit 5160d11 into master Mar 24, 2017
@philippjfr philippjfr deleted the elop_ndlayout branch April 11, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A major new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants