Added custom rcParam context manager #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
jlstevens
reviewed
Apr 17, 2017
holoviews/plotting/mpl/plot.py
Outdated
| @@ -19,12 +20,27 @@ | |||
| from .util import compute_ratios, fix_aspect | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def rc_context(rcparams): | |||
There was a problem hiding this comment.
To avoid confusion maybe this should be _rc_context if we expect to use the decorator and not this context manager directly. Perhaps you could even inline this context manager inside mpl_rc_context?
There was a problem hiding this comment.
Inlining seems inefficient but I'll happily rename.
There was a problem hiding this comment.
I don't think it is at all inefficient to inline - decorators are only applied once at definition time.
|
Looks good apart from one comment. It is suspicious that the context manager supplied by matplotlib doesn't seem to work right... |
|
This fix seems to work for me 👍 |
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the context manager to set rcParams provided by matplotlib is not working correctly, I've implemented a tiny one of our own here which fixes the bug mentioned in #1299.