Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Unified redim implementation with convenience methods #1302
This PR unifies redim and makes it much more convenient to use, which is especially helpful for DynamicMap declarations. You can now do:
Instead of the more verbose equivalent we have been using till now:
Even for this simplest possible example with only a single kdim, the new style is shorter.
All existing use of redim should act in exactly the same way. What is new are all the redim auxiliary methods that make it easier to pick a particular Dimension parameter to change.
I've added 10 unit tests of the auxiliary redim method. They are very simple and the core redim method is well tests already.
@philippjfr I think this PR is ready for review. I hope to get it merged ASAP as I have some nice improvements to DynamicMap usage that builds on top of this.
Agreed. I would definitely split it up into subclasses if the current redim