Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for constructing empty Dataset types #1355

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 23, 2017

All Dataset interfaces except the deprecated NdElement interface now support constructing an empty dataset of the right shape when given an empty list. If you can think of another specification that should also mean empty that would be trivial to add. I think this capability is important when working with streams because often your selection, streamed data or whatever else is empty to begin with and constructing an empty Element can often be a pain.

@jlstevens
Copy link
Contributor

Looks good.

I would like unit tests for all possible empty constructors though (i.e across data types).

@philippjfr
Copy link
Member Author

I would like unit tests for all possible empty constructors though (i.e across data types).

That's the beauty of Dataset tests, you get a unit test per data type for every one you write.

@jlstevens
Copy link
Contributor

Great! Happy to merge if you think it is ready and the tests go green.

@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens jlstevens merged commit 0214f41 into master Apr 23, 2017
@jlstevens jlstevens deleted the empty_dataset_support branch April 26, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants