Allowed using xarray with dask arrays #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
approved these changes
Jun 2, 2017
|
Looks good! I had a prototype line like this once before but supporting dask via xarray makes sense. My main comment is that a few unit tests would be nice (marked optional and dask would need to be available on travis). |
|
I'm now running all existing Dataset tests against an xarray dataset containing dask arrays. Those 60 unit tests should cover it pretty well. |
|
I'll merge when the tests go green. |
|
Hold off on merging, found some issues. |
|
Okay, now fixed. Ready to merge once tests pass. |
|
Tests have passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XArray supports wrapping around dask arrays. Generally this doesn't cause any issues but the
dimension_valuesmethod should always return an in-memory NumPy array so this PR is sufficient for us to have full support for dask arrays via xarray.