Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clone on NdLayout to propagate cols properly #1739

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Copy link
Contributor

jlstevens commented Jul 20, 2017

PR title explains the change. My only worry is why does the id need to be copied across, doesn't super handle that?

@jlstevens jlstevens added the bug label Jul 20, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Jul 20, 2017

I want to figure out whether the propagation of id is really needed before merging.

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Jul 23, 2017

Note, this PR addresses #1738.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Jul 30, 2017

I want to figure out whether the propagation of id is really needed before merging.

It definitely is Layout.clone does the same thing. A clone of an Element should resets any custom options while a Layout should not. I'm happy to merge if you think it's ready.

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Jul 30, 2017

A clone of an Element should resets any custom options while a Layout should not.

Ok. That makes sense, in which case this is ready to merge.

@philippjfr philippjfr merged commit 32fe7a6 into master Jul 31, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 79.616%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the ndlayout_clone_fix branch Jul 31, 2017

ea42gh added a commit to ea42gh/holoviews that referenced this pull request Aug 12, 2017

@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.