Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed clone on NdLayout to propagate cols properly #1739

Merged
merged 1 commit into from Jul 31, 2017
Merged

Fixed clone on NdLayout to propagate cols properly #1739

merged 1 commit into from Jul 31, 2017

Conversation

jlstevens
Copy link
Contributor

PR title explains the change. My only worry is why does the id need to be copied across, doesn't super handle that?

@jlstevens jlstevens added the type: bug Something isn't correct or isn't working label Jul 20, 2017
@jlstevens
Copy link
Contributor Author

I want to figure out whether the propagation of id is really needed before merging.

@jlstevens
Copy link
Contributor Author

Note, this PR addresses #1738.

@philippjfr
Copy link
Member

I want to figure out whether the propagation of id is really needed before merging.

It definitely is Layout.clone does the same thing. A clone of an Element should resets any custom options while a Layout should not. I'm happy to merge if you think it's ready.

@jlstevens
Copy link
Contributor Author

A clone of an Element should resets any custom options while a Layout should not.

Ok. That makes sense, in which case this is ready to merge.

@philippjfr philippjfr merged commit 32fe7a6 into master Jul 31, 2017
@philippjfr philippjfr deleted the ndlayout_clone_fix branch July 31, 2017 22:57
ea42gh pushed a commit to ea42gh/holoviews that referenced this pull request Aug 12, 2017
@jlstevens @ea42gh
Fixed clone on NdLayout to propagate cols properly (holoviz#1739)
7f6534a
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlstevens @philippjfr