Fix bokeh version import #2113
Closed
Fix bokeh version import #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokeh_version was not imported, causes problem at line 422, atleast when running bokeh app
|
Thanks for catching this, I've already made the fix in #2112. This check is no longer needed, so I've just removed it. We'll likely merge the fix tomorrow and then release 1.9.1 with the fix on Sunday. |
|
thanks! my baby steps to atleast make some contribution. |
|
Your contribution was definitely appreciated, and really it's on us to provide some material for contributors to get started! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bokeh_version import otherwise leads to
line 422, in set_server_callback if self.on_events and bokeh_version >= '0.12.5': NameError: name 'bokeh_version' is not definedatleast while serving a bokeh app.