Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid interface reindex #2746

Merged
merged 3 commits into from May 28, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented May 28, 2018

This ensures that GridInterface.reindex has the same behavior as NdMapping.reindex, which is to drop scalar dimensions automatically. Also fixes a bug in XArrayInterface.ndloc uncovered in the process of writing tests for the new reindex functionality.

  • Fixes #2362
  • Adds unit test
@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented May 28, 2018

Ready to merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented May 28, 2018

Any worries about people relying on the old behavior? Otherwise looks good. Merging.

@jlstevens jlstevens merged commit 8030410 into master May 28, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on grid_interface_reindex at 82.747%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the grid_interface_reindex branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.