Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DictInterface only validates referenced columns #2855

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jul 4, 2018

Disables validation for columns which are not referenced as a dimension in the DictInterface. It can be useful to store other data in the dictionary and validation should not prevent non-standard data from being stored when HoloViews will just ignore that data anyway.

@philippjfr philippjfr added the data label Jul 4, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jul 4, 2018

I suppose that makes sense though you'll hit an error eventually if you decide to visualize an incorrectly formatted vdim (for instance). Anyway, it does seem worth being permissive about data not actually being used.

Ready to merge?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jul 4, 2018

Yes, ready.

@jlstevens jlstevens merged commit 435f00c into master Jul 4, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 82.939%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dict_validation branch Aug 5, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.