Handle zero ranges correctly in regrid operation #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevieb Would you mind testing this? |
philippjfr
force-pushed
the
rasterize_empty
branch
from
c83c36e
to
79c9eba
Compare
|
@philippjfr that seemed better in that all of the images don't disappear when you zoom in but now there is a new problem. Once the image is entirely out of the viewport it disappears and never comes back. |
Odd, I haven't been able to reproduce that. I'll have another look. |
philippjfr
force-pushed
the
rasterize_empty
branch
from
79c9eba
to
6239007
Compare
|
Nevermind ran into the issue in a completely separate context and fixed it. Thanks for your help @stevievb. |
philippjfr
force-pushed
the
rasterize_empty
branch
from
517d8f8
to
22e3235
Compare
|
@jlstevens This is ready to merge once tests pass. |
philippjfr
force-pushed
the
rasterize_empty
branch
from
5bc7e4c
to
94fdd67
Compare
philippjfr
force-pushed
the
rasterize_empty
branch
from
94fdd67
to
6ddd4fc
Compare
|
Looks good to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I fixed the zero range handling in the aggregate operation I seemingly did not do it properly in the regrid operation. Additionally this PR allows Images to contain arrays with a (0, 0) shape, which previously required a hack which would instead store a (1, 1) image.