Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for handling of curvilinear coordinates #3017

Merged
merged 10 commits into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Sep 26, 2018

  • Adds support for constructing curvilinear xarray dataset from literals
  • Fixes bug where rasterization would flip QuadMesh
  • Fixes bug where canonicalization would flip value dimension arrays when curvilinear coordinate arrays are used (this is unnecessary and caused various bugs)

@philippjfr philippjfr changed the title Fixes for handling of QuadMesh Fixes for handling of curvilinear coordinates Sep 26, 2018

Philipp Rudiger Philipp Rudiger
@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Sep 26, 2018

Ready to review and merge.

@philippjfr philippjfr force-pushed the qmesh_orientation_fixes branch from 9e43f97 to e1c4526 Sep 27, 2018

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the qmesh_orientation_fixes branch from e1c4526 to f184182 Sep 27, 2018

Philipp Rudiger added some commits Sep 27, 2018

@philippjfr philippjfr force-pushed the qmesh_orientation_fixes branch from 4d95103 to 5926a87 Sep 27, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Sep 28, 2018

Looks good and having a bunch more unit tests is comforting. As this PR is intended as a set of fixes only with no new features, I'll go ahead and merge.

@jlstevens jlstevens merged commit f565370 into master Sep 28, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 83.574%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the qmesh_orientation_fixes branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.