Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for handling of curvilinear coordinates #3017

Merged
merged 10 commits into from
Sep 28, 2018
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 26, 2018

  • Adds support for constructing curvilinear xarray dataset from literals
  • Fixes bug where rasterization would flip QuadMesh
  • Fixes bug where canonicalization would flip value dimension arrays when curvilinear coordinate arrays are used (this is unnecessary and caused various bugs)

@philippjfr philippjfr changed the title Fixes for handling of QuadMesh Fixes for handling of curvilinear coordinates Sep 26, 2018
@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: component: data labels Sep 26, 2018
@philippjfr
Copy link
Member Author

Ready to review and merge.

@jlstevens
Copy link
Contributor

Looks good and having a bunch more unit tests is comforting. As this PR is intended as a set of fixes only with no new features, I'll go ahead and merge.

@jlstevens jlstevens merged commit f565370 into master Sep 28, 2018
@philippjfr philippjfr deleted the qmesh_orientation_fixes branch November 12, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants