Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trimesh_rasterize value dimension handling #3050

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

philippjfr
Copy link
Member

Makes a number of changes and fixes to trimesh rasterization:

  • A value dimension defined on the nodes takes precedence over one defined on the tris
  • If an explicit aggregator is defined that column is actually respected

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Oct 5, 2018
@jlstevens
Copy link
Contributor

Changes seem reasonable though are there any backwards compatibility implications of changing how the value dimensions are handled?

@philippjfr philippjfr added this to the v1.11 milestone Oct 5, 2018
@philippjfr
Copy link
Member Author

Changes seem reasonable though are there any backwards compatibility implications of changing how the value dimensions are handled?

Yes, but @jbednar and I agreed that this behavior is definitely preferable. We should simply make sure to document this in the release notes.

@jlstevens
Copy link
Contributor

Ok, as long as we don't forget to mention this in the release notes I'm fine with this change. Merging.

@jlstevens jlstevens merged commit 086a0d1 into master Oct 5, 2018
@philippjfr philippjfr deleted the trimesh_rasterize branch November 12, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants