Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trimesh_rasterize value dimension handling #3050

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Oct 5, 2018

Makes a number of changes and fixes to trimesh rasterization:

  • A value dimension defined on the nodes takes precedence over one defined on the tris
  • If an explicit aggregator is defined that column is actually respected

@philippjfr philippjfr added the bug label Oct 5, 2018

@philippjfr philippjfr force-pushed the trimesh_rasterize branch from 2fea4b2 to b70f1e7 Oct 5, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 5, 2018

Changes seem reasonable though are there any backwards compatibility implications of changing how the value dimensions are handled?

@philippjfr philippjfr added this to the v1.11 milestone Oct 5, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Oct 5, 2018

Changes seem reasonable though are there any backwards compatibility implications of changing how the value dimensions are handled?

Yes, but @jbednar and I agreed that this behavior is definitely preferable. We should simply make sure to document this in the release notes.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 5, 2018

Ok, as long as we don't forget to mention this in the release notes I'm fine with this change. Merging.

@jlstevens jlstevens merged commit 086a0d1 into master Oct 5, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 83.119%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the trimesh_rasterize branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.