Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode fixes for SelectionWidget #376

Merged
merged 1 commit into from Dec 20, 2015

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Dec 20, 2015

This PR fixes various issues with unicode dimension labels and values in the SelectionWidget as seen in #350. It is a quick fix to deal with unicode specifically for the widgets, but in the long term we should switch to unicode everywhere as I started to do in #352.

Philipp Rudiger Philipp Rudiger
@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Dec 20, 2015

Tests are passing, this is ready to merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Dec 20, 2015

Ok merging.

jlstevens added a commit that referenced this pull request Dec 20, 2015

Merge pull request #376 from ioam/unicode_quickfix
Unicode fixes for SelectionWidget

@jlstevens jlstevens merged commit a1bffb4 into master Dec 20, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 70.222%
Details

@jlstevens jlstevens deleted the unicode_quickfix branch Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.