Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensioned.clone always transfers id to new object #439

Merged
merged 2 commits into from Feb 3, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 3, 2016

This PR will make sure styles are transferred when applying various operations to an object including slices. This will probably affect some existing tests but it is better behavior.

@philippjfr philippjfr added this to the v1.4.2 milestone Feb 3, 2016

@philippjfr philippjfr self-assigned this Feb 3, 2016

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 3, 2016

Ok, the tests are passing and I do think this is a good change. Merging.

jlstevens added a commit that referenced this pull request Feb 3, 2016

Merge pull request #439 from ioam/propagate_id
Dimensioned.clone always transfers id to new object

@jlstevens jlstevens merged commit 50f2295 into master Feb 3, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 69.731%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr referenced this pull request Feb 3, 2016

Closed

Slicing removes styling #423

@jlstevens jlstevens deleted the propagate_id branch Feb 4, 2016

@jlstevens jlstevens restored the propagate_id branch Feb 4, 2016

@jlstevens jlstevens deleted the propagate_id branch Feb 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.