Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort `values` in hv.Dimension #916

Merged
merged 2 commits into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@basnijholt
Copy link
Contributor

basnijholt commented Oct 10, 2016

No description provided.

basnijholt added some commits Oct 10, 2016

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 10, 2016

I think this makes sense - sliders require an ordering to work (by definition) so sorting seems sensible.

Happy to merge when the tests pass.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 10, 2016

PR build passed. @jlstevens should we merge?

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 10, 2016

I assume the push build is only there when HoloViews devs make PRs?

Anyway, I am happy to see this PR merged now the tests have passed. Merging.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 10, 2016

Only branches get push builds.

@jlstevens jlstevens merged commit 0698861 into pyviz:master Oct 10, 2016

2 of 3 checks passed

s3-reference-data-cache Tests still building.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.842%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.