Fixes #1312 Fixed IndexError in tomof() of some CIM objects on empty array value #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2018
… on empty array value Details: * Fixed the issue where `CIMInstance.tomof()` raised `IndexError` when it contains an array property whose value is the empty array. This would also happen in `CIMProperty.tomof(is_instance=True,...)` on an empty array value. The value of the empty array is represented as an empty string, and this is now checked before accessing it. * Extended fix to also cover CIMQUalifier and CIMQUalifierDeclaration. * Added according testcases to test_cim_obj.py. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
andy/#1312-fix-tomof-empty-array
branch
from
ede2422
to
ab3a8d2
Compare
andy-maier
changed the title
KSchopmeyer
approved these changes
Jul 20, 2018
andy-maier
added
the
roll back/forward done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review and merge.