Fixes #1312 Fixed IndexError in tomof() of some CIM objects on empty array value

PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.2
 Name: pywbem
-Version: 0.12.1.dev54
+Version: 0.12.1.dev59
 Summary: pywbem - A WBEM client
 Home-page: http://pywbem.github.io/pywbem/
 Author: Tim Potter

docs/changes.rst

@@ -123,6 +123,13 @@ Released: not yet
   variables. They are no longer imported into the `pywbem` namespace.
   See issue #1302.
 
+* Fixed issue where the `tomof()` methods of `CIMProperty`, `CIMQualifier`,
+  and `CIMQualifierDeclaration` raised `IndexError` when the value was
+  an empty array. This issue perculated up to higher level CIM objects
+  that are using these objects, i.e. `CIMInstance` or `CIMClass`.
+  Added according testcases.
+  See issue #1312.
+
 **Enhancements:**
 
 * Extend pywbem MOF compiler to search for dependent classes including:

pywbem/cim_obj.py

@@ -4782,7 +4782,8 @@ def tomof(
                 val_str, line_pos = _value_tomof(
                     self.value, self.type, indent + MOF_INDENT, maxline,
                     line_pos + 1, 1, True)
-                if val_str[0] != '\n':
+                # Empty arrays are represented as val_str=''
+                if val_str and val_str[0] != '\n':
                     # The extra space was actually needed
                     mof.append(u' ')
                 else:
@@ -4798,6 +4799,7 @@ def tomof(
                 val_str, line_pos = _value_tomof(
                     self.value, self.type, indent + MOF_INDENT, maxline,
                     line_pos + 1, 1, True)
+                # Scalars cannot be represented as val_str=''
                 if val_str[0] != '\n':
                     # The extra space was actually needed
                     mof.append(u' ')
@@ -6602,7 +6604,8 @@ def tomof(self, indent=MOF_INDENT, maxline=MAX_MOF_LINE, line_pos=0):
         # Assume in line_pos that the extra space would be needed
         val_str, line_pos = _value_tomof(
             self.value, self.type, indent, maxline, line_pos + 1, 3, True)
-        if val_str[0] != '\n':
+        # Empty arrays are represented as val_str=''
+        if val_str and val_str[0] != '\n':
             # The extra space was actually needed
             mof.append(u' ')
         else:

testsuite/test_cim_obj.py

@@ -12062,6 +12062,19 @@ class Test_CIMProperty_tomof(object):
             P1 = 42;\n""",
             None, True
         ),
+        (
+            "instance uint32 array property, empty array",
+            CIMProperty(
+                name='P1',
+                value=list(),
+                type='uint32',
+                is_array=True,
+            ),
+            True, 12,
+            u"""\
+            P1 = { };\n""",
+            None, CHECK_0_12_0
+        ),
         (
             "instance uint32 array property, single-line",
             CIMProperty(
@@ -15463,6 +15476,17 @@ class Test_CIMQualifier_tomof(object):  # pylint: disable=too-few-public-methods
             u"""Q1 ("vt=\\f,cr=\\r")""",
             None, True
         ),
+        (
+            "string array that is empty",
+            CIMQualifier(
+                name='Q1',
+                value=[],
+                type='string',
+            ),
+            12,
+            u"""Q1 { }""",
+            None, CHECK_0_12_0
+        ),
         (
             "string array with a value of two items",
             CIMQualifier(
@@ -29156,6 +29180,21 @@ class Test_CIMQualifierDeclaration_tomof(object):
     Scope();""",
             None, True
         ),
+        (
+            "string array of variable size that has an empty array value",
+            CIMQualifierDeclaration(
+                name='Q1',
+                type='string',
+                is_array=True,
+                array_size=None,
+                value=[],
+            ),
+            u"""\
+Qualifier Q1 : string[] = {  },
+    Scope();
+""",
+            None, CHECK_0_12_0
+        ),
         (
             "string array of variable size",
             CIMQualifierDeclaration(