Performance improvement 12: Optimize NocaseDict._real_key() #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - The initialization of CIMProperty and CIMParameter always performs a check on the array-related parameters via _check_array_parms(). However, in case is_array was inferred, it is set consistently by _infer_is_array() and there is no point in checking it again. This change performs the _check_array_parms() only if is_array was not inferred. This change leaves the following combination of incorrect input parameter undetected: is-array=False and array_size=5. Because array_size is ignored and has no meaning when is_array=False, not detecting this check seems acceptable. The improvement is to avoid the call to _check_array_parms() when is_array is inferred. - An additional improvement was possible due to the first change, namely to not perform the check for is-array=False and array_size=5 at all, and to eliminate an assertion because the way the check function is called already ensures that. Improvement: Output files before: perf/tupleparse/perf_9-infer_* Output files after: perf/tupleparse/perf_10-checkarray_* Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Details: - This change optimizes the NocaseDict.__init__() method for the case that is by far the most common: No arguments. For that case, it reduces the number of if's from 3 if's each with len(), to 2 if's for non-emptiness, plus it eliminates a dict update() with empty input. - This change also improves some comments in NocaseDict.__init__(). Improvement: Output files before: perf/tupleparse/perf_10-checkarray_* Output files after: perf/tupleparse/perf_11-nocasedict_* Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/perf-12-nocasedict
branch
from
19450c4
to
e1f95aa
Compare
Details: - This change optimizes the implementaiton of NocaseDict._real_key() by replacing a check using isinstance() with a check for None, turning around the order of checks. Also, replaced if/elif/else with a sequence of if's. This eliminates a call to isinstance(). Improvement: Output files before: perf/tupleparse/perf_11-nocasedict_* Output files after: perf/tupleparse/perf_12-nocasedict_* Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/perf-12-nocasedict
branch
from
e1f95aa
to
f7024d5
Compare
KSchopmeyer
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see last commit