Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partly fixes #86: Test: Fixed ResourceWarning issued in test_mof_compiler.py #2496

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Partly fixes #86: Test: Fixed ResourceWarning issued in test_mof_compiler.py #2496

merged 1 commit into from
Oct 10, 2020

Conversation

andy-maier
Copy link
Contributor

See commit message.

@andy-maier
Test: Fixed ResourceWarning issued in test_mof_compiler.py
c77b52d 
Detail:

* In test_mof_compiler.py, removed unnecessary open() calls in
  test functions when the file was already opened in a setUp()
  method. Made one test class to be derived from MOFTest to
  inherit the setUp() method that opens the log file.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier changed the title Test: Fixed ResourceWarning issued in test_mof_compiler.py Partly fixes #86: Test: Fixed ResourceWarning issued in test_mof_compiler.py Oct 10, 2020
@andy-maier andy-maier self-assigned this Oct 10, 2020
@andy-maier andy-maier added this to the 1.2.0 milestone Oct 10, 2020
@andy-maier andy-maier mentioned this pull request Oct 10, 2020
Closed
@coveralls
Copy link

coveralls commented Oct 10, 2020 •
edited

Coverage Status

Coverage decreased (-0.002%) to 90.706% when pulling c77b52d on andy/reswarn-mofcompiler into db890fd on master.

@andy-maier andy-maier mentioned this pull request Oct 10, 2020
Merged
@andy-maier andy-maier linked an issue Oct 10, 2020 that may be closed by this pull request
ResourceWarnings in py3 during test #86
Closed
@andy-maier andy-maier merged commit 0d2e5d8 into master Oct 10, 2020
@andy-maier andy-maier deleted the andy/reswarn-mofcompiler branch October 10, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSchopmeyer KSchopmeyer KSchopmeyer approved these changes

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

ResourceWarnings in py3 during test
3 participants
@andy-maier @coveralls @KSchopmeyer