Added ability to disable logging; Fixed ResourceWarnings in test_logging.py #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
changed the title
andy-maier
force-pushed
the
try/reswarn-logging
branch
from
bdcbc11
to
6e74d10
Compare
andy-maier
force-pushed
the
try/reswarn-logging
branch
3 times, most recently
from
44c0d00
to
fb33122
Compare
KSchopmeyer
approved these changes
Oct 10, 2020
…ing.py Details: * Added a value 'off' for the log destination in the ``pywbem.configure_logging()`` function that disables logging. * The key point to address the ResourceWarning about unclosed log file was to close the log handler when processing the new log dest 'off'. * Adjusted testcases to disable logging at the end using the new log dest 'off'. * Because this PR addresses the last remaining set of ResourceWarnings, the makefile was changed to no longer ignore ResourceWarnings. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
try/reswarn-logging
branch
from
fb33122
to
6fc4362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is on top of PR #2496 - review only the last commit.
Together, these PRs remove all remaining ResourceWarnings during test.
See commit message for details.