Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate recent pywbem 1.0.0 changes #640

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

andy-maier
Copy link
Contributor

@andy-maier andy-maier commented Jun 21, 2020

See commit message.

Tested the PR locally against the master branch of pywbem (as of commit 9ad299b).
The CI runs will test the PR against pywbem 0.17.2.

@coveralls
Copy link

coveralls commented Jun 21, 2020

Coverage Status

Coverage remained the same at 90.674% when pulling b28b117 on andy/fix-pywbem-10 into c21ad59 on master.

Details:

* Removed the use of the 'property_list' init parameter for CIMInstance
  in create_ciminstance().

* In test_common.py, accomodated the fact that CIMInstanceName.to_wbem_uri()
  now by default sorts the keybindings.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Copy link
Contributor

@KSchopmeyer KSchopmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also just havemoved Boolean property to be first property. Works for all.

Andy: I know, but I wanted to explicitly validate the reordering that is done by the new sorting behavior.

@andy-maier andy-maier merged commit 967457d into master Jun 23, 2020
@andy-maier andy-maier deleted the andy/fix-pywbem-10 branch June 23, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants