Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed default connections file to .pywbemcli_connections.yaml #728

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

andy-maier
Copy link
Contributor

No description provided.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier self-assigned this Aug 12, 2020
@andy-maier andy-maier added this to the 0.8.0 milestone Aug 12, 2020
@andy-maier andy-maier linked an issue Aug 12, 2020 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage decreased (-0.001%) to 91.934% when pulling 96f16e7 on andy/rename-connections-file into 1d9c615 on master.

Copy link
Contributor

@KSchopmeyer KSchopmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make one comment about how we tell people that this change occurred.

Says something when we change 7 files but only one is the actual change and that is one line.

docs/changes.rst Show resolved Hide resolved
Details:

* In _load_connections_file(), added support for migrating an old default
  connections file to the new name: If pywbemcli is invoked with the default
  connections file and it does not exist, but the old default connections
  file exists, it is renamed to the new default name and a message is
  issued about this.

* This required also performing this migration in the file_exists()
  method, which now calls _load_connections_file().

* Improved the message reporting connections file not found.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier merged commit 3691c37 into master Aug 16, 2020
@andy-maier andy-maier deleted the andy/rename-connections-file branch August 16, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change base file name of connections file
3 participants