Test: Added testcases for Python tell/truncate #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/tell-tests
branch
from
8ab2f53
to
11394a3
Compare
|
My tendency would be to keep it. Does not hurt anything and continues to point out the issue. I assume we remove it when we remove support for python 2.7 |
|
We decided to keep it, and to document why it is there |
andy-maier
force-pushed
the
andy/tell-tests
branch
from
11394a3
to
2e4ceef
Compare
|
Documented why it is there. Karl approved it verbally in the meerting. |
Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier
force-pushed
the
andy/tell-tests
branch
from
2e4ceef
to
c5756b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real test for this is in PR #79 which has been rebased on this PR.
Update: That test succeeded for all environments, see particularly Appveyor build https://ci.appveyor.com/project/KSchopmeyer/pywbemtools/builds/35071137
DISCUSSION: What should we do with this test, keep it in pywbemtools?