Getting the credits correct (hopefully) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github makes reviewing errors a lot easier, so I'm going pick a few of them off now. |
pc494
commented
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Getting the credits correct (hopefully)
about: Details in #97 and #98
Release Notes
What does this PR do? Please describe and/or link to an open issue.
Means that Rob is on the credits, get code a little better organised, will be followed with a couple of tidy up PR's, but it would be good to get this in soon to minimise the number of conflicts in other PR's
** ALSO NOTE ** ~ would prefer a squash merge on this one please.