-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credits for Rob Tovey #98
Credits for Rob Tovey #98
Conversation
Great, thanks for this, I'll get to work on the merge conflicts :) EDIT: turns out this is slightly more involved than originally anticipated. |
I know this is non-ideal - but I do think that we should just accept that a mistake was made and move on, it seems like a lot of effort to resolve for not a lot of benefit? |
I had another think about this last night and I don't actually think it will work anyway. Any changes which I originally made and are still in the master wont conflict so they wont change so they wont gain my reference. Overall, this is probably a lot of work for absolutely no change at all... |
Sorry, do you think we can confirm which way this is heading? I'm sorry I made a bit of a mess there but maybe the best thing to do is just let this slide into history...? |
I think I could make this work, but I've yet to get around to it, if the thing I was planning doesn't get it there I'll give up and, like you say, let it slide into history (if you could leave this PR open that would help though! :) ) |
That's fine with me. I just hope you don't waste too much time on it. |
Pull request to address issue #97.
Original commits in #33 did not log correct details for contribution.
Reverted to original branch then moved forward to final merging commit to link with my account.
Hopefully now it will be easier for people to complain when they find all my bugs ;)