Remove unused imports

[hakonanes]

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

---

name: Pull request
about: Remove unused imports

---

What does this PR do? Please describe and/or link to an open issue.
All unused imports are removed. All tests pass locally.

Describe alternatives you've considered
There are also some places in the code where functions have parameters they don't use (e.g. https://github.com/pyxem/diffsims/blob/master/diffsims/generators/diffraction_generator.py#L200), and lines of code irrelevant for the output (https://github.com/pyxem/diffsims/blob/master/diffsims/libraries/diffraction_library.py#L140). This is not me being extremely attentive, it's just PyCharm showing unused variables with some transparency.

Should I remove this in this PR?

Work in progress?

• Remove unused function parameters and code bits

[pc494]

This is good & was on my list of things to do at some point. What did you use to automate this?

[hakonanes]

This is good & was on my list of things to do at some point. What did you use to automate this?

Went through all the files by hand...

[pc494]

ah. We can add "look up a way to automate this" for the future, for now you dedraft this and I'll merge it.

[hakonanes]

Could you just quickly tell me if I should remove the unused bits mentioned in part 2 of my top comment?

[pc494]

sorry, was being slow and hadn't clocked pyCharm caught more than just imports!

1. leave the magnitude_tolerance, I'll catch it in the sweep in Sweeping for release: ProfileSimulation and updated dependancies #119
2. you can leave the other one too, I'll deal with it in the sweep as the code is a bit more wrong than the highlighting suggests

summary: this is good as is, will use #119 to address the leftovers

[tjof2]

flake8 and a similar config to that in pyxem would make it simpler to automatically identify things like this. F401 is an unused import. You can even make it part of the tests with pytest-flake8...

https://github.com/pyxem/pyxem/blob/3e9662c7a78c488e6d1844986bb53d0eb4fbbb8d/setup.cfg#L23