Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweeping for release: ProfileSimulation and updated dependancies #119

Merged
merged 11 commits into from
Sep 14, 2020

Conversation

pc494
Copy link
Member

@pc494 pc494 commented Sep 7, 2020


name: Sweeping for release, ProfileSimulation, updated dependancies,
about: Closes #116 by removing the g_max argument (if somebody needs it it's an easy fix, and you should aim not to simulate more peaks than you want to plot) and removes the "marked failure" for rotation_lists that relied on the local gridding function. This was fixed in pyxem/orix#118


Release Notes

improvement
Summary: g_max argument removed from plotting ProfileSimulations

@pc494
Copy link
Member Author

pc494 commented Sep 7, 2020

NOTE ~ This will fail the test until we release orix 0.5.0

@pc494 pc494 mentioned this pull request Sep 11, 2020
3 tasks
@hakonanes
Copy link
Member

By the way, I'm being told by PyCharm that this line https://github.com/pyxem/diffsims/blob/master/diffsims/generators/diffraction_generator.py#L277 is invalid since y is a list which does not define __truediv__. Should perhaps fix this in this PR, since it is somewhat related?

@pc494
Copy link
Member Author

pc494 commented Sep 11, 2020

Yep, will fix that here as it's clearly got a code smell to it.

@pc494 pc494 mentioned this pull request Sep 11, 2020
@pc494
Copy link
Member Author

pc494 commented Sep 14, 2020

To do:

  • ProfileSimulation gmax argument clean up
  • get_library_entry clean up
  • Fix magnitude_tolerance in ProfileSimulation.calculate_ed_data()
  • automate release workflow
  • bump version to 0.3.0

@dnjohnstone dnjohnstone merged commit fa01d17 into pyxem:master Sep 14, 2020
@pc494 pc494 added this to the v0.3.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

g_max argument not used in the get_plot method of DiffractionSimulation
3 participants