-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweeping for release: ProfileSimulation and updated dependancies #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE ~ This will fail the test until we release orix 0.5.0 |
By the way, I'm being told by PyCharm that this line https://github.com/pyxem/diffsims/blob/master/diffsims/generators/diffraction_generator.py#L277 is invalid since |
Yep, will fix that here as it's clearly got a code smell to it. |
Merged
To do:
|
…nto sweep-for-three Merge github version into local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Sweeping for release, ProfileSimulation, updated dependancies,
about: Closes #116 by removing the
g_max
argument (if somebody needs it it's an easy fix, and you should aim not to simulate more peaks than you want to plot) and removes the "marked failure" for rotation_lists that relied on the local gridding function. This was fixed in pyxem/orix#118Release Notes