Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hexagonal corners of fundamental sector in stereographic projection #184

Merged
merged 4 commits into from May 31, 2022
Merged

Fix hexagonal corners of fundamental sector in stereographic projection #184

merged 4 commits into from May 31, 2022

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented May 27, 2022 •
edited by pc494

Description of the change

Change the rounded hexagonal corner [10-10] to the exact [9 1 -10 0]. See #183 for details.

Also fixed a rounding error in a test when coordinates passed to DiffractionSimulation where integers and not floats.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.

@hakonanes
Change hexagonal fund. sector corner from [10-10] to [9 1 -10 0]
77cca4f 
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Update changelog
f9099e8 
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Test size of grid sampled from each crystal systems
60095c2 
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label May 27, 2022
@hakonanes hakonanes added this to the v0.5.0 milestone May 27, 2022
This was referenced May 27, 2022
Closed
Merged
@hakonanes
Set diffraction sim. coordinates as floats to avoid rounding error
4cd9938 
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes requested a review from pc494 May 27, 2022 19:17
pc494
pc494 approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM

@pc494 pc494 merged commit 22ad2f7 into pyxem:master May 31, 2022
@hakonanes hakonanes deleted the fix-183 branch May 31, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pc494 pc494 pc494 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakonanes @pc494