Skip to content

Conversation

@hakonanes
Copy link
Member

@hakonanes hakonanes commented May 12, 2022

Description of the change

These are some minor preparations for a 0.5 release:

  • Most importantly, diffsims is tested using orix v0.9.0rc2: no code changes were necessary!
  • The contributor list is updated. @pc494, if you want a .zenodo.json file here as well, I'll add it. .zenodo.json file added.
  • I've updated the Python publish workflow to use the same as with orix. I thought we could test this by releasing 0.5.0rc1 before 0.5.0. This way, I can also test kikuchipy against diffsims 0.5.0.
  • Bumped version to 0.5.0rc1
  • Updated the license description in setup.py from GPLv3 to GPLv3+, because the license allows for a later v3 license to be used as well. hyperspy does this. There isn't a later v3 as far as I know.
  • Removed passing the convention parameter to Rotation.from_euler() which was deprecated in orix 0.9

Question: should we add a black code style check to the CI build action?

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.

hakonanes added 6 commits May 12, 2022 16:18
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the dev label May 12, 2022
@hakonanes hakonanes added this to the v0.5.0 milestone May 12, 2022
@hakonanes hakonanes marked this pull request as draft May 13, 2022 09:23
@pc494
Copy link
Member

pc494 commented May 13, 2022

This looks good to me so far, I do think a .zenodo file would be good.

hakonanes added 2 commits May 15, 2022 13:46
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes added 3 commits May 18, 2022 18:16
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes marked this pull request as ready for review May 18, 2022 16:34
@hakonanes
Copy link
Member Author

@pc494 could you make me a maintainer of diffsims on PyPI? With the updated publish workflow, we have to add tokens named PYPI_API_TOKEN and TEST_PYPI_API_TOKEN with tokens from both PyPI and TestPyPI to repo secrects (and can delete the PyPI username and password).

hakonanes added 2 commits May 19, 2022 19:49
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member Author

The meaning of direction=crystal2lab changed from orix 0.8.2 to direction=lab2crystal in 0.9.0. from_euler() is used when generating rotation lists. In order for diffsims to stay consistent, I changed use of from_euler() to use the default direction, which is lab2crystal, and set the minimal version of orix to 0.9.0.

@hakonanes
Copy link
Member Author

See #183 raised by @emichr, which must be fixed before releasing diffsims 0.5.0.

@pc494
Copy link
Member

pc494 commented May 20, 2022

@pc494 could you make me a maintainer of diffsims on PyPI? With the updated publish workflow, we have to add tokens named PYPI_API_TOKEN and TEST_PYPI_API_TOKEN with tokens from both PyPI and TestPyPI to repo secrects (and can delete the PyPI username and password).

I was considering make pyxem team credentials with PyPi to clean up this part of the workflow? Would now be a suitable time to do that?

@hakonanes
Copy link
Member Author

Do you mean making a pyxem team PyPI user? With the pyxem mail?

@pc494
Copy link
Member

pc494 commented May 20, 2022

Do you mean making a pyxem team PyPI user? With the pyxem mail?

That was my thought?

@hakonanes
Copy link
Member Author

I'm OK with that. Could you send me the password for PyPI and TestPyPI after creation?

@pc494
Copy link
Member

pc494 commented May 20, 2022

I'm OK with that. Could you send me the password for PyPI and TestPyPI after creation?

I'll find a secure way to circulate those details to you. The main point was to use them as the automated once in github. Also, before then I'll add you (normal account) to diffsims, sorry for the delay on that.

@hakonanes hakonanes mentioned this pull request May 27, 2022
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member Author

The two failing tests were fixed in #184.

@hakonanes
Copy link
Member Author

I'll fix the conflict myself, and then this PR is ready.

hakonanes added 2 commits June 1, 2022 12:17
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
… into prepare-0.5.0-release

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes requested a review from pc494 June 1, 2022 10:24
Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@pc494 pc494 merged commit 70a0797 into pyxem:master Jun 1, 2022
@hakonanes hakonanes deleted the prepare-0.5.0-release branch June 1, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants