-
Notifications
You must be signed in to change notification settings - Fork 27
Minor preparations for a 0.5 release #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
|
This looks good to me so far, I do think a |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
|
@pc494 could you make me a maintainer of diffsims on PyPI? With the updated publish workflow, we have to add tokens named |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
|
The meaning of |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This reverts commit 1180b4b.
I was considering make pyxem team credentials with PyPi to clean up this part of the workflow? Would now be a suitable time to do that? |
|
Do you mean making a pyxem team PyPI user? With the pyxem mail? |
That was my thought? |
|
I'm OK with that. Could you send me the password for PyPI and TestPyPI after creation? |
I'll find a secure way to circulate those details to you. The main point was to use them as the automated once in github. Also, before then I'll add you (normal account) to diffsims, sorry for the delay on that. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
|
The two failing tests were fixed in #184. |
|
I'll fix the conflict myself, and then this PR is ready. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
… into prepare-0.5.0-release Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
pc494
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging.
Description of the change
These are some minor preparations for a 0.5 release:
diffsimsis tested usingorixv0.9.0rc2: no code changes were necessary!if you want a .zenodo.json file here as well, I'll add it..zenodo.json file added.orix. I thought we could test this by releasing 0.5.0rc1 before 0.5.0. This way, I can also testkikuchipyagainstdiffsims0.5.0.hyperspydoes this. There isn't a later v3 as far as I know.conventionparameter toRotation.from_euler()which was deprecated in orix 0.9Question: should we add a
blackcode style check to the CI build action?Progress of the PR
masterbefore release:For reviewers
__init__.py.unreleased section in
CHANGELOG.rst.