Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence Numba warnings by always using no-python mode #194

Merged
merged 3 commits into from
May 23, 2023

Conversation

hakonanes
Copy link
Member

Description of the change

Force no-python mode with Numba to silence deprecation warnings raised in 0.57.0. The warning can be seen e.g. in a recent kikuchipy PR test check.

Since this warning is displayed to users of kikuchipy with Numba >= v0.57.0, I'd like for this patch to be released immediately. I've therefore bumped the version to 0.5.2 and updated the changelog.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in credits in diffsims/release_info.py and
    in .zenodo.json.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the dev label May 21, 2023
@hakonanes hakonanes added this to the v0.5.2 milestone May 21, 2023
@hakonanes hakonanes requested a review from pc494 May 21, 2023 19:50
@pc494
Copy link
Member

pc494 commented May 23, 2023

@hakonanes,

this seems okay to me, could you just explain the move from jit to njit to that we have a record? Then happy to merge and get to work on the release.

@hakonanes
Copy link
Member Author

Thanks for having a look. njit is an alias for jit(nopython=True) and is just a convenience (see last sentence in this paragraph in the Numba docs).

@pc494
Copy link
Member

pc494 commented May 23, 2023

Thanks for having a look. njit is an alias for jit(nopython=True) and is just a convenience (see last sentence in this paragraph in the Numba docs).

could have looked that up myself, but thanks :D, merging.

Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, let's go.

@pc494 pc494 merged commit ff1a56b into pyxem:main May 23, 2023
@hakonanes hakonanes deleted the silence-numba-warnings branch May 23, 2023 11:40
@hakonanes
Copy link
Member Author

could have looked that up myself, but thanks :D

Correct, but it was a valid question, and something I should have given a reason for in the top comment!

merging

🎉

@hakonanes
Copy link
Member Author

I've made a release draft, which I plan to publish within the next hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants