Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's left before a minor release v0.3 late 2020 #235

Closed
22 tasks done
hakonanes opened this issue Oct 22, 2020 · 10 comments
Closed
22 tasks done

What's left before a minor release v0.3 late 2020 #235

hakonanes opened this issue Oct 22, 2020 · 10 comments
Assignees
Labels
maintenance This relates to package maintenance
Milestone

Comments

@hakonanes
Copy link
Member

hakonanes commented Oct 22, 2020

List of issues and PRs that I think should be concluded before we release v0.3:

I hope we can get this ready for late November early January.

@friedkitteh and @onatlandsmyr, please add or change any tasks if necessary.

@hakonanes hakonanes added the maintenance This relates to package maintenance label Oct 22, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Oct 22, 2020
@hakonanes hakonanes self-assigned this Oct 22, 2020
@hakonanes hakonanes pinned this issue Oct 22, 2020
@hakonanes
Copy link
Member Author

hakonanes commented Nov 14, 2020

Great work, @friedkitteh and @onatlandsmyr!

Now that both the static pattern matching and sampling of simulated patterns from the master pattern are in, I see that there are mostly changes to the user guide and improvements to the EBSD class metadata/property handling left. My plan is to work on the notebook user guides with a workflow I would like to use, and make changes when I encounter something that doesn't work quite as desired.

I'm confident we will get this out in a (really awesome) v0.3 release early-to-mid december.

@hakonanes
Copy link
Member Author

hakonanes commented Nov 29, 2020

Due to #251, I propose we try to release v0.3 this month, and rather release some patches, since with HyperSpy 1.6.1, the kikuchipy.io._io.save() method is broken (fix in #250).

@hakonanes
Copy link
Member Author

The goal is to include the two current PRs and then release a release candidate as diffsims and pyxem has done lately.

@pc494
Copy link
Member

pc494 commented Jan 14, 2021

Just as a note.

I didn't find release candidates that useful generally (conda doesn't acknowledge them). The diffsims one was primarily so that I had a fixed commit to build pyxem on top of, and the pyxem one for building the demos unrelated to new functionality. Given the structure of kikuchipy you might I would just release it once you're happy with it.

@hakonanes
Copy link
Member Author

Thanks for the note. It's seven months since the last release, so I just want to be sure everything goes as planned.

@pc494
Copy link
Member

pc494 commented Jan 14, 2021

Thanks for the note. It's seven months since the last release, so I just want to be sure everything goes as planned.

Makes sense, (that was why I built a couple for orix a while back, but most of my problems tended to be at the conda stage)

@hakonanes
Copy link
Member Author

The release candidate is available here https://pypi.org/project/kikuchipy/0.3.0rc1/ as

> conda create -n kp-0.3.0rc1 python=3.8
> conda activate kp-0.3.0rc1
> pip install kikuchipy[dev]==0.3.0rc1
> pytest --pyargs kikuchipy

@hakonanes
Copy link
Member Author

Will publish the v0.3.0 release tag tomorrow morning.

@hakonanes
Copy link
Member Author

v0.3.0 is now available via PyPI 🎉! In a couple of hours, it should be available via conda-forge as well.

@hakonanes hakonanes unpinned this issue Jan 22, 2021
@hakonanes
Copy link
Member Author

The conda-forge feedstock was just updated, v0.3.1 should be available via conda shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

No branches or pull requests

2 participants