Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions + IO bug fix #250

Merged
merged 15 commits into from
Nov 29, 2020

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Nov 29, 2020

Description of the change

  • Replace Travis CI with GitHub Actions, i.e. ensure the package can be installed on all platforms with Python 3.7 and 3.8, and subsequently that the test suite passes
  • See Change to ensure_directory() func in HyperSpy 1.6.1 breaks kikuchipy.io._io.save() #251 For some reason I don't know most IO tests fail on the GitHub Action's virtual machines (called runners). The tests pass locally. These tests are marked with @pytest.mark.xfail so the test suite will return green even though those tests fail. Until a solution is found, the coverage will be reduced to about 97%. Introduce fix proposed in mentioned issue.
  • Update contributing guide
  • Update changelog
  • Remove Travis CI scripts
  • Replace Travis CI README badge with GitHub Actions badge
  • Remove conda-forge version and black code style badge, add total downloads badge from PePy
  • Coverage to 100% by adding test for EBSDMasterPattern.get_patterns()

Closes #248.

Progress of the PR

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added maintenance This relates to package maintenance tests This relates to the tests labels Nov 29, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Nov 29, 2020
@hakonanes hakonanes self-assigned this Nov 29, 2020
@hakonanes
Copy link
Member Author

#251 is also the reason for the doc build failing.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes changed the title Replace Travis CI with GitHub Actions Replace Travis CI with GitHub Actions + bug fix Nov 29, 2020
@hakonanes hakonanes changed the title Replace Travis CI with GitHub Actions + bug fix Replace Travis CI with GitHub Actions + IO bug fix Nov 29, 2020
@hakonanes hakonanes added the bug Something isn't working label Nov 29, 2020
@hakonanes
Copy link
Member Author

Will merge when all checks pass.

@hakonanes hakonanes merged commit fce4cb6 into pyxem:master Nov 29, 2020
@hakonanes hakonanes deleted the use-github-actions branch November 29, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance This relates to package maintenance tests This relates to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Travis CI with GitHub Actions to run CI builds
1 participant