-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometrical EBSD simulation notebook #281
Geometrical EBSD simulation notebook #281
Conversation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Failing tests are related to me removing the private attribute |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
The tests now fail because I forgot to remove the rotation of orientations used by the test from TSL's to Bruker's sample reference frame here: https://github.com/pyxem/kikuchipy/blob/master/kikuchipy/conftest.py#L171 |
I'll follow up this PR with another PR creating a notebook out of the reference frame reST file, where the conventions will be updated. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Actually, it's much simpler to use Bruker's PC convention since their PC origin is in the upper left corner of the detector, which is also how matplotlib plots arrays. Thus, I think we should stick with TSL's sample reference frame but Bruker's PC convention. |
Description of the change
EBSDSimulationGenerator
and theGeometricalEBSDSimulation
classesGeometricalEBSDSimulation
Progress of the PR
diffsims.crystallography.ReciprocalLatticePoint._hkldata
tohkldata
Use EDAX TSL pattern center definition instead of BrukerFor reviewers
later.
__init__.py
.the unreleased section in
doc/changelog.rst
.