Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalibrationLibrary is no longer in use #1041

Closed
pc494 opened this issue Mar 21, 2024 · 1 comment · Fixed by #1043
Closed

CalibrationLibrary is no longer in use #1041

pc494 opened this issue Mar 21, 2024 · 1 comment · Fixed by #1043
Assignees
@pc494
Labels
deletion-candidate functionality that unless someone objects will be removed by 1.0.0

Comments

@pc494
Copy link
Member

pc494 commented Mar 21, 2024

I think when @CSSFrancis rebuilt calibration we got rid of the need for this. Is that correct? If so it's a very quick deprecation we can sneak in before v1.0.0
@pc494 pc494 added the deletion-candidate functionality that unless someone objects will be removed by 1.0.0 label Mar 21, 2024
@CSSFrancis
Copy link
Member

Let's do it!

@pc494 pc494 self-assigned this Mar 22, 2024
pc494 added a commit to pc494/pyxem that referenced this issue Mar 22, 2024
@pc494
deprecation: CalibrationDataLibrary, closes pyxem#1041
dfe35f3
@pc494 pc494 mentioned this issue Mar 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pc494 pc494

Labels
deletion-candidate functionality that unless someone objects will be removed by 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecating CalibrationDataLibrary and our Pyfai detectors modules pc494/pyxem
2 participants
@pc494 @CSSFrancis