Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating CalibrationDataLibrary and our Pyfai detectors modules #1043

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

pc494
Copy link
Member

@pc494 pc494 commented Mar 22, 2024


name: Deprecating CalibrationDataLibrary and our Pyfai detectors modules


Checklist

What does this PR do? Please describe and/or link to an open issue.
trivial, closes #1041 and closes #1042

@pc494 pc494 added deletion-candidate functionality that unless someone objects will be removed by 1.0.0 needs review labels Mar 22, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.142%. first build
when pulling f95f7e9 on pc494:deprecations-libraries-detectors
into fa939ca on pyxem:main.

@pc494
Copy link
Member Author

pc494 commented Mar 22, 2024

This is trivial, and the isses were pre-approved. Self-merging, moving the changelog update to #1040

@pc494 pc494 merged commit ba578ff into pyxem:main Mar 22, 2024
16 checks passed
@pc494 pc494 mentioned this pull request Mar 22, 2024
pc494 added a commit to pc494/pyxem that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deletion-candidate functionality that unless someone objects will be removed by 1.0.0 needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Detector module will no longer have a use after 0.18.0 CalibrationLibrary is no longer in use
2 participants