Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #52 : Added Help Command to CLI #60

Closed
wants to merge 6 commits into from
Closed

Fixes #52 : Added Help Command to CLI #60

wants to merge 6 commits into from

Conversation

ish-u
Copy link
Contributor

@ish-u ish-u commented Oct 10, 2020 •
edited

CHANGELOG 馃摑

  • added help command

LABELS

@pyymenta
Copy link
Owner

Thanks @ish-u! I'll review it soon!

@pyymenta pyymenta added enhancement New feature or request hacktoberfest labels Oct 12, 2020
pyymenta
pyymenta reviewed Oct 12, 2020
View reviewed changes
src/cli.ts Outdated
Comment on lines 80 to 97

const helpEvent = this.keyListener.bindEvent({
keyName: ['h'],
handler: function (keyName) {
console.log(`
Start => Earth(0, 0)
Goal => Moon(0, 250)

Once Launched, the Ship moves Forward

W -> Increase Forward Speed
S -> Decrease Forward Speed
A -> Move Left
D -> Move Right
Max Speed - 5 speedunit
Min Speed - 1 speedunit (after leaving (0, 0))

Press H -> Show the Ship Reference Manual
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃殌

@ish-u Could you add a message here with the instructions to access the help screen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i will do that today

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the instruction to access Help Screen.

ish-u and others added 3 commits October 13, 2020 11:20
@ish-u
added instruction to access Help Screen
a983818
@sudiptog81 @M4yankChoudhary
@guilhermeorcezi @pyymenta
Merge conflict resolution with pyymenta/spacecraft-cli (#1)
f46e6fd 
* Create .eslintignore

* dist folder added to eslintignore

* added code coverage and ci config

* fix lint issues

* remove unnecessary import

* fix lint issues

* fix rocket on init

* Our rocket is back in your initialization

* revert dist files

* feat: add help command

Co-authored-by: Mayank Choudhary <7mayankchoudhary7@gmail.com>
Co-authored-by: Guilherme Orcezi <guilhermeorcezi@gmail.com>
Co-authored-by: Lucas <lucas.pimenta94@outlook.com>
@sudiptog81 @M4yankChoudhary
@guilhermeorcezi @pyymenta
Merge conflict resolution trial 2 (#2)
4b2ed4c 
* Create .eslintignore

* dist folder added to eslintignore

* added code coverage and ci config

* fix lint issues

* remove unnecessary import

* fix lint issues

* fix rocket on init

* Our rocket is back in your initialization

* revert dist files

* feat: add help command

* fix further conflicts

Co-authored-by: Mayank Choudhary <7mayankchoudhary7@gmail.com>
Co-authored-by: Guilherme Orcezi <guilhermeorcezi@gmail.com>
Co-authored-by: Lucas <lucas.pimenta94@outlook.com>
@sudiptog81
Copy link
Contributor

sudiptog81 commented Oct 13, 2020 •
edited

There were some merge conflicts where I had to help @ish-u, we should mention in CONTRIBUTING.md for contributors to work on their own branch and keep master in sync with upstream. You can squash and merge this PR keeping contents of this PR.

This was referenced Oct 13, 2020
Merged
Closed
@pyymenta
Copy link
Owner

There were some merge conflicts where I had to help @ish-u, we should mention in CONTRIBUTING.md for contributors to work on their own branch and keep master in sync with upstream. You can squash and merge this PR keeping contents of this PR.

Thanks for your suggestion, I'll add this information in CONTRIBUTING.md. Although we are unable to merge this PR because we still have some conflicts that we need to fix.

@pyymenta pyymenta mentioned this pull request Oct 14, 2020
Merged
@ish-u
Copy link
Contributor Author

ish-u commented Oct 15, 2020

@pyymenta
Please merge #64 to fix #52 as it doesn't have any conflicts and close this PR.
Sorry if my PR caused any trouble.

@pyymenta
Copy link
Owner

@pyymenta
Please merge #64 to fix #52 as it doesn't have any conflicts and close this PR.
Sorry if my PR caused any trouble.

No problem man, feel free to take another challenge! Again, thanks for your contribuition! 馃 馃

@pyymenta pyymenta closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyymenta pyymenta pyymenta left review comments

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add help command to the CLI
3 participants
@ish-u @pyymenta @sudiptog81