Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Help Command to CLI #64

Merged
merged 12 commits into from Oct 15, 2020

Conversation

sudiptog81
Copy link
Contributor

@sudiptog81 sudiptog81 commented Oct 13, 2020

CHANGELOG 馃摑

Only to be used in case merge resolution fails. I'll close this in case #60 succeeds.

ish-u and others added 10 commits October 10, 2020 20:48
* Create .eslintignore

* dist folder added to eslintignore

* added code coverage and ci config

* fix lint issues

* remove unnecessary import

* fix lint issues

* fix rocket on init

* Our rocket is back in your initialization

* revert dist files

* feat: add help command

Co-authored-by: Mayank Choudhary <7mayankchoudhary7@gmail.com>
Co-authored-by: Guilherme Orcezi <guilhermeorcezi@gmail.com>
Co-authored-by: Lucas <lucas.pimenta94@outlook.com>
@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #64 into master will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   34.42%   33.87%   -0.56%     
==========================================
  Files           8        8              
  Lines         122      124       +2     
  Branches       17       17              
==========================================
  Hits           42       42              
- Misses         79       81       +2     
  Partials        1        1              
Impacted Files Coverage 螖
src/cli.ts 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a8e2ab8...a8cbf96. Read the comment docs.

@sudiptog81 sudiptog81 marked this pull request as ready for review October 13, 2020 07:10
@pyymenta pyymenta self-requested a review October 14, 2020 03:09
@pyymenta pyymenta added enhancement New feature or request hacktoberfest labels Oct 14, 2020
@pyymenta
Copy link
Owner

@sudiptog81 Thank you about your contribution and your engagement to help. That's a good plan! Thank you!

Comment on lines +85 to +105
this.keyListener.bindEvent({
keyName: 'h',
handler: function () {
console.log(`
Start => Earth(0, 0)
Goal => Moon(0, 250)

Once Launched, the Ship moves Forward

W -> Increase Forward Speed
S -> Decrease Forward Speed
A -> Move Left
D -> Move Right
Max Speed - 5 speedunit
Min Speed - 1 speedunit (after leaving (0, 0))

Press H -> Show the Ship Reference Manual
Press CTRL + C to Exit
`);
}
});
Copy link
Owner

@pyymenta pyymenta Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 馃 馃 馃

}

start(): void {
console.log(Welcome);
console.log(Rocket);

this.output.write('(0, 0) ready for launch\n');
this.output.write('(0, 0) ready for launch\nPress H to Show Help\n');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌 馃殌 馃殌

Copy link
Owner

@pyymenta pyymenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @sudiptog81

Thank you so much!

@pyymenta pyymenta merged commit 508518d into pyymenta:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add help command to the CLI
4 participants