Compatibility with PyQt5

[ghisvail]

The Python ecosystem is slowly but surely transitioning to Qt5. Are there any plans to make pyzo compatible with PyQt5 (and perhaps PySide2 later) in the future? Perhaps using a shim layer like the spyder guys did?

[Nodd]

For reference, git-cola used qtpy for the transition, here is the relevant issue if you're interested in the discussion: git-cola/git-cola#232
(disclaimer: I'm a qtpy/spyder dev).

[almarklein]

I think that makes sense. Now to find the time to do it :)

[ghisvail]

How much work do you reckon this would require?

[almarklein]

I find it hard to guess. I recon that it won't be too much, since Pyzo uses the new-style PyQt already. Though I don't know what problems will come up. Possibly using qtpy might help.

[ghisvail]

Is pyzo.util.qt the only place in the code that should be modified to make pyzo support qtpy or pyqt5 ?

[almarklein]

yes, all code in Pyzo eventually loads it from that module.

[almarklein]

About done, except testing on PySide / PyQt5: #433

[ghisvail]

Do you want me to try it out with PyQt5? SincePyQt5 is packaged as a wheel on PyPI, it should be quite straightforward.

Overall, what's left to be done for the next stable release to happen?

[almarklein]

what's left to be done for the next stable release to happen?

I want to have a look at the binaries for Linux; whether updating Qt, or using PyQt5 fixes these nasty issues we're having.

I you want to try out PyQt5 with this branch that would be helpful, thanks!

[ghisvail]

I you want to try out PyQt5 with this branch that would be helpful, thanks!

I'll spin up a venv with PyQt5 and the dev snapshot and program in it for the day. I'll report anything unusual.

[ghisvail]

QStringListModel in QtCore not QtWidgets.

QStringListModel.diff.txt

[ghisvail]

Here is the full diff I had to apply to allow Pyzo to load with PyQt5.

load_with_pyqt5.diff.txt

Hope this helps.

[ghisvail]

And a little screenshot!

[almarklein]

Awesome! Thanks for that @ghisvail !

[ghisvail]

Nothing bad to report. Shall I turn the .diff into a PR?

[almarklein]

Shall I turn the .diff into a PR?

Please :D