Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/abi: add a testcase for handling hex and bin strings #101

Merged
merged 6 commits into from
May 19, 2022
Merged

Conversation

q9f
Copy link
Owner

@q9f q9f commented May 19, 2022

No description provided.

@q9f q9f changed the title Q9f/abi/test eth/abi: add a testcase for handling hex and bin strings May 19, 2022
@q9f q9f added the refactor Improving the architecture label May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #101 (1922e24) into main (bbbb8ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          67       67           
  Lines        3807     3812    +5     
=======================================
+ Hits         3797     3802    +5     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth/abi.rb 100.00% <100.00%> (ø)
spec/eth/abi_spec.rb 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@q9f q9f merged commit 5eee050 into main May 19, 2022
@q9f q9f deleted the q9f/abi/test branch May 19, 2022 13:09
mculp pushed a commit to mculp/eth.rb that referenced this pull request Aug 1, 2022
* eth/abi: fix handling of hex values for byte strings

* eth/abi: add a testcase for handling hex and bin strings

* eth/abi: fix handling of hex values for byte strings

* spec: run rufo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improving the architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants