Issue349 imtool3 d td #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blue button for help + help for trackpads
|
Great! Thanks @tanguyduval ! What's your thoughts on handling the conflicting files? It appears the y are too complex to view on GitHub. Should we just use the ones in this branch to overwrite the one in master? Or are the ones in master possibly modified from the base imtool3D ones, and overwriting them would result in missing features/lines of code neeed for your _td mods? |
# Conflicts: # External/imtool3D_td/imtool3D.m # External/imtool3D_td/imtool3D_3planes.m # External/imtool3D_td/imtool3D_nii_3planes.m # External/imtool3D_td/src/load_nii_datas.m
|
@mathieuboudreau I just did the merge. I used the new version and overwrote master with new versions of imtool3D. |
mathieuboudreau
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
This PR perfectly fixes #349. I went through the PR review checklist and everything pass fine.
Thanks a lot @tanguyduval !!
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
solve #349
Approach
in nii_load.m, Apply use the scaling and convert to double automatically. If output takes more than 300Mb of memory consumption ask the user.
These changes were already done in dicm2nii and imtool3D. So I just updated these two External repo with their latest version.
Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications
Reviewer
@mathieuboudreau