Fix isempty bug for doc data download #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 47.40% 47.40%
=======================================
Files 260 260
Lines 8654 8654
=======================================
Hits 4102 4102
Misses 4552 4552
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
agahkarakuzu
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug through the qsm_sb model.
Basically, when using the GUI, downloading the demo qsm_sb data results in the partial dataset being downloaded and not the full dataset.
This is because although
getenv('ISDOC')is an empty char array, astr2double()of a char array results in a NaN, not an empty value, and thus~isempty(str2double(getenv('ISDOC')))is true even when not in aISDOCenv.