perf(smileys): Cleanup smileys icons by timer

qTox · Nov 13, 2017 · fa21594 · fa21594
1 parent c640007
commit fa21594
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 5 deletions.
diff --git a/src/persistence/smileypack.cpp b/src/persistence/smileypack.cpp
@@ -25,6 +25,7 @@
 #include <QRegularExpression>
 #include <QStandardPaths>
 #include <QtConcurrent/QtConcurrentRun>
+#include <QTimer>
 
 #if defined(Q_OS_FREEBSD)
 #include <locale.h>
@@ -58,6 +59,8 @@ static const QString RICH_TEXT_PATTERN = QStringLiteral("<img title=\"%1\" src=\
 
 static const QString EMOTICONS_FILE_NAME = QStringLiteral("emoticons.xml");
 
+static constexpr int CLEANUP_TIMEOUT = 5 * 60 * 1000; // 5 minutes
+
 /**
  * @brief Construct list of standard directories with "emoticons" sub dir, whether these directories
  * exist or not
@@ -101,13 +104,34 @@ QString getAsRichText(const QString& key)
     return RICH_TEXT_PATTERN.arg(key);
 }
 
-
 SmileyPack::SmileyPack()
+    : cleanupTimer{new QTimer(this)}
 {
     loadingMutex.lock();
     QtConcurrent::run(this, &SmileyPack::load, Settings::getInstance().getSmileyPack());
     connect(&Settings::getInstance(), &Settings::smileyPackChanged, this,
             &SmileyPack::onSmileyPackChanged);
+    connect(cleanupTimer, &QTimer::timeout, this, &SmileyPack::cleanup);
+    cleanupTimer->start(CLEANUP_TIMEOUT);
+}
+
+SmileyPack::~SmileyPack()
+{
+    delete cleanupTimer;
+}
+
+void SmileyPack::cleanup()
+{
+    QMutexLocker locker(&loadingMutex);
+    for (auto it = emoticonToIcon.begin(); it != emoticonToIcon.end();) {
+        std::shared_ptr<QIcon>& icon = it->second;
+        if (icon.use_count() == 1) {
+            it = emoticonToIcon.erase(it);
+            icon.reset();
+        } else {
+            ++it;
+        }
+    }
 }
 
 /**
@@ -242,7 +266,7 @@ QString SmileyPack::smileyfied(const QString& msg)
         QString key = match.captured();
         int startPos = match.capturedStart();
         int keyLength = key.length();
-        if (emoticonToPath.contains(key)) {
+        if (emoticonToPath.find(key) != emoticonToPath.end()) {
             QString imgRichText = getAsRichText(key);
             result.replace(startPos + replaceDiff, keyLength, imgRichText);
             replaceDiff += imgRichText.length() - keyLength;
@@ -269,7 +293,7 @@ QList<QStringList> SmileyPack::getEmoticons() const
 std::shared_ptr<QIcon> SmileyPack::getAsIcon(const QString& emoticon)
 {
     QMutexLocker locker(&loadingMutex);
-    if (emoticonToIcon.contains(emoticon))
+    if (emoticonToIcon.find(emoticon) != emoticonToIcon.end())
         return emoticonToIcon[emoticon];
 
     const auto iconPathIt = emoticonToPath.find(emoticon);
@@ -279,7 +303,7 @@ std::shared_ptr<QIcon> SmileyPack::getAsIcon(const QString& emoticon)
 
     const QString& iconPath = iconPathIt.value();
     auto icon = std::make_shared<QIcon>(iconPath);
-    emoticonToIcon.insert(emoticon, icon);
+    emoticonToIcon[emoticon] = icon;
     return icon;
 }
 

diff --git a/src/persistence/smileypack.h b/src/persistence/smileypack.h
@@ -26,6 +26,8 @@
 
 #include <memory>
 
+class QTimer;
+
 class SmileyPack : public QObject
 {
     Q_OBJECT
@@ -41,18 +43,21 @@ class SmileyPack : public QObject
 
 private slots:
     void onSmileyPackChanged();
+    void cleanup();
 
 private:
     SmileyPack();
     SmileyPack(SmileyPack&) = delete;
     SmileyPack& operator=(const SmileyPack&) = delete;
+    ~SmileyPack() override;
 
     bool load(const QString& filename);
 
-    QMap<QString, std::shared_ptr<QIcon>> emoticonToIcon;
+    std::map<QString, std::shared_ptr<QIcon>> emoticonToIcon;
     QHash<QString, QString> emoticonToPath;
     QList<QStringList> emoticons;
     QString path;
+    QTimer* cleanupTimer;
     mutable QMutex loadingMutex;
 };