Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

No application file in distributive #3801

Closed
PKEv opened this issue Oct 9, 2016 · 7 comments
Closed

No application file in distributive #3801

PKEv opened this issue Oct 9, 2016 · 7 comments
Assignees
Labels
M-packaging Affected Module: Packaging OS-windows

Comments

@PKEv
Copy link
Contributor

PKEv commented Oct 9, 2016

in archive by link: 64 bit portable (https://build.tox.chat/job/qTox_build_windows_x86-64_release/lastSuccessfulBuild/artifact/qTox_build_windows_x86-64_release.zip)
no file of application

@Diadlo
Copy link
Member

Diadlo commented Oct 9, 2016

Seems duplicatoe of closed (why?) #3557

@Diadlo Diadlo added M-packaging Affected Module: Packaging OS-windows labels Oct 9, 2016
@sudden6
Copy link
Member

sudden6 commented Oct 9, 2016

I closed it because when I checked, the build contained an executable. Maybe this problem happens only to some builds?

@rodolpheh
Copy link

Could you reopen it ? It seems that the executable is not present since the last four builds (since October 15th).

initramfs added a commit to initramfs/qTox that referenced this issue Oct 25, 2016
With the removal of RTTI such a cast can cause compile failures as not
all compilers automatically convert dynamic casts to static casts at
compile time.

Fixes qTox#3801
@initramfs
Copy link
Contributor

@rodolpheh Issue confirmed. The issue seems to be that when Jenkins fails a compile, it doesn't quit out, listing it as a successful compile. As such, when packaging no qtox.exe is available since it doesn't exist.

The current issue stems from commit abaa41e which removes RTTI. Unfortunately one instance of code requiring RTTI still existed and didn't play well with the compiler on Jenkins. PR #3830 fixes this issue.

@zetok
Copy link
Contributor

zetok commented Oct 25, 2016

The issue seems to be that when Jenkins fails a compile, it doesn't quit out, listing it as a successful compile. As such, when packaging no qtox.exe is available since it doesn't exist.

@nurupo / @optimumtact could you fix that?

@initramfs
Copy link
Contributor

@zetok I submitted issue #3831 to track that problem since this issue will get autoclosed as soon as PR #3830 gets merged.

@nurupo
Copy link
Contributor

nurupo commented Oct 26, 2016

@zetok replied in #3831

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M-packaging Affected Module: Packaging OS-windows
Projects
None yet
Development

No branches or pull requests

8 participants