You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
[21:46:59.694 UTC] core/core.cpp:1569 : Debug: "Trying to join AV groupchat invite sent by friend 5"
[21:46:59.694 UTC] persistence/profile.cpp:358 : Debug: Saving tox save to "/home/abilinski/.config/tox/qTest2.tox"
[21:46:59.954 UTC] core/core.cpp:922 : Debug: "Group 3 peerlist changed"
[21:46:59.954 UTC] core/core.cpp:931 : Debug: "Group 3, Peer 0, name changed to Alice"
[21:46:59.954 UTC] core/core.cpp:922 : Debug: "Group 3 peerlist changed"
[21:46:59.954 UTC] core/core.cpp:931 : Debug: "Group 3, Peer 1, name changed to Bob"
[21:46:59.954 UTC] core/core.cpp:922 : Debug: "Group 3 peerlist changed"
[21:46:59.954 UTC] core/core.cpp:143 : Critical: Peer not found
[21:46:59.959 UTC] persistence/profile.cpp:358 : Debug: Saving tox save to "/home/abilinski/.config/tox/qTest2.tox"
[21:47:00.147 UTC] core/core.cpp:931 : Debug: "Group 3, Peer 2, name changed to qTest2"
qtox: /home/abilinski/builds/qTox/src/model/group.cpp:129: void Group::updateUsername(ToxPk, QString): Assertion `peerDisplayNames.contains(pk)' failed.
Expected Behavior
We don't assert.
Additional Info
Since we don't usually hit this and I was using gdb at the time, we possibly have a race condition between different signals coming from Core working their ways up to Gorup.
The text was updated successfully, but these errors were encountered:
I also hit this a lot more often than before - it seems much more common with a 4 person group compared to a 3 person group. I'm going to bump priority and bring it into the release milestone, since it made group calls almost unusable for me, especially when combined with TokTok/c-toxcore#961 (comment), which makes you mute in the group if you crash during a call. My friends and I were in a loop of creating new groups, crashing because of this, becoming mute, then having to repeat 😡
The call to Core::getGroupPeerNames is expected to return a list where
the index in the list is the group member id. In any error case we were
previously breaking this constraint. It turns out that every time
someone joins a group we call this function before they have a valid
name resulting in their id not being added to the list.
This fix ensures that the list coming out of Core::getGroupPeerNames
always has a full list.
FixesqTox#5838
The call to Core::getGroupPeerNames is expected to return a list where
the index in the list is the group member id. In any error case we were
previously breaking this constraint. It turns out that every time
someone joins a group we call this function before they have a valid
name resulting in their id not being added to the list.
This fix ensures that the list coming out of Core::getGroupPeerNames
always has a full list.
FixesqTox#5838
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
C-crashThe issue contains a crash reportD-easyWe estimate that the issue is easy to fixP-mediumU-highUser Impact: High
Brief Description
OS: Ubuntu 18.04
qTox version: v1.16.3+
Commit hash: bd034e1
toxcore: v0.2.10
Qt: 5.9.5
Hardware: Desktop
Reproducible: Often
Steps to reproduce
Observed Behavior
Expected Behavior
We don't assert.
Additional Info
Since we don't usually hit this and I was using gdb at the time, we possibly have a race condition between different signals coming from Core working their ways up to Gorup.
The text was updated successfully, but these errors were encountered: