Better error message for NamedConstructorAggregateFactory assertion #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
||
| Assert::true( | ||
| method_exists($aggregateClass, $this->staticConstructorMethod), | ||
| sprintf('NamedConstructorAggregateFactory expected %s to exists', $methodCall) |
There was a problem hiding this comment.
Good one, that's what you get when you rearrange your sentence last minute :)
wjzijderveld
force-pushed
the
assertion-message
branch
from
b9226bf
to
36a7027
Compare
|
👍 I've run into this multiple times and was fortunate enough to have @wjzijderveld there this time to keep track of these things and submit issues and fixes for broadway today. :) |
|
👍 |
othillo
pushed a commit
that referenced
this pull request
Jun 25, 2015
Better error message for NamedConstructorAggregateFactory assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174